-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix zero-dimensional reverse!
#58086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed the check to compare against the tuple argument, instead of against the method static parameter for the tuple length. Should be better when the length isn't known at compile time. Fixes JuliaLang#58085
jishnub
reviewed
Apr 12, 2025
As mentioned in the PR description, I believe changing julia> f(dims::NTuple{M}) where {M} = M == 0
f (generic function with 1 method)
julia> g(dims::NTuple{M}) where {M} = dims === ()
g (generic function with 1 method)
julia> code_typed(f, Tuple{Tuple{Any,Vararg}})
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = $(Expr(:static_parameter, 1))::Int64
│ %2 = builtin (%1 === 0)::Bool
└── return %2
) => Bool
julia> code_typed(g, Tuple{Tuple{Any,Vararg}})
1-element Vector{Any}:
CodeInfo(
1 ─ return false
) => Bool |
KristofferC
pushed a commit
that referenced
this pull request
Apr 14, 2025
51 tasks
KristofferC
pushed a commit
that referenced
this pull request
Apr 25, 2025
71 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jun 4, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arrays
[a, r, r, a, y, s]
backport 1.10
Change should be backported to the 1.10 release
backport 1.11
Change should be backported to release-1.11
bugfix
This change fixes an existing bug
collections
Data structures holding multiple items, e.g. sets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed the check to compare against the tuple argument, instead of against the method static parameter for the tuple length. Should be better when the length isn't known at compile time.
Fixes #58085