subtype: save some union stack space for ∃ free cases. #58159
Conversation
N5N3
added
types and dispatch
vtjnash
added
the
needs pkgeval
and avoid eager UnionAll unwrapping to hit more fast path.
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed1 packages crashed only on the current version.
6 packages crashed on the previous version too. ✖ Packages that failed44 packages failed only on the current version.
1248 packages failed on the previous version too. ✔ Packages that passed tests12 packages passed tests only on the current version.
5316 packages passed tests on the previous version too. ~ Packages that at least loaded4 packages successfully loaded only on the current version.
2937 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether918 packages were skipped on the previous version too. |
|
@nanosoldier |
|
The package evaluation job you requested has completed - no new issues were detected. Report summary✖ Packages that failed11 packages failed on the previous version too. ✔ Packages that passed tests24 packages passed tests on the previous version too. ~ Packages that at least loaded1 packages successfully loaded only on the current version.
9 packages successfully loaded on the previous version too. |
N5N3
removed
the
needs pkgeval
KristofferC
removed
the
backport 1.12
and avoid eager UnionAll unwrapping to hit more fast path. close JuliaLang#58129 (test passed locally) close JuliaLang#56350 (MWE returns `Tuple{Any, Any, Vararg}` now.)
project_prop_on_subset! function has been changed so that it does not restrict the input type anymore. The input type restriction was causing too much overhead in compilation (potentially a julia issue) but we aren't wining anything right now by fixing the type. The overhead comes when during compile time the script does not know the type of the input. This was happening in the second method which takes a string path from the ggd array to the property. Since this string path can be anything, the compiler goes into endless computation in pre-compile step and gets stuck without giving any warning or errors. I suspect another overflow issue similar to JuliaLang/julia#58129 fixed in JuliaLang/julia#58159 .
Fixed projection function on ggd array project_prop_on_subset! function has been changed so that it does not restrict the input type anymore. The input type restriction was causing too much overhead in compilation (potentially a julia issue), but we aren't winning anything right now by fixing the type. The overhead comes when, during compile time, the script does not know the type of the input. This was happening in the second method, which takes a string path from the ggd array to the property. Since this string path can be anything, the compiler goes into endless computation inthe pre-compile step and gets stuck without giving any warning or errors. I suspect another overflow issue similar to JuliaLang/julia#58129 fixed in JuliaLang/julia#58159 .
KristofferC
removed
the
backport 1.11
and avoid eager UnionAll unwrapping to hit more fast path.
close #58129 (test passed locally)
close #56350 (MWE returns
Tuple{Any, Any, Vararg}now.)