Refactor show_typeparams
#58244
Draft
Refactor show_typeparams
#58244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/performat_depth_limited_printing_peel_off
branch
from
c06ae8b to
69e789c
Compare
|
your commits seem a bit messed up. |
The first build had lots of errors that I didn't recognize in terms of the changes in the commit, so I reverted everything (plus a small test-file change) to see if CI was broken, or if it was actually related to my PR. |
charleskawczynski
force-pushed
the
ck/performat_depth_limited_printing_peel_off
branch
from
2b6bc7a to
69e789c
Compare
|
Reverting that now to see if it's fixed since the last build seemed to pass. |
charleskawczynski
force-pushed
the
ck/performat_depth_limited_printing_peel_off
branch
2 times, most recently
from
24891d7 to
3b9cc92
Compare
|
Again, it would be nice to include justification for this PR to help folks understand why they should consider volunteering to review and merge it. |
charleskawczynski
force-pushed
the
ck/performat_depth_limited_printing_peel_off
branch
3 times, most recently
from
83f7a6a to
f62c65b
Compare
charleskawczynski
force-pushed
the
ck/performat_depth_limited_printing_peel_off
branch
2 times, most recently
from
522ea5a to
eeaed6b
Compare
charleskawczynski
force-pushed
the
ck/performat_depth_limited_printing_peel_off
branch
from
eeaed6b to
c557d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
show_typeparamsso that we can form a string of the type params, in addition to showing it.This PR peels off some work in #58240.