fix isconst definition/accessor issues with binding partitions #58261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing due a Documenter bug now correctly exposed by this fix (JuliaDocs/Documenter.jl#2693) |
53 tasks
oscardssmith
added
merge me
58 tasks
|
Now we hit a different Documenter bug, introduced in the latest minor release (https://github.com/JuliaDocs/Documenter.jl/pull/2676/files#r2082477911) |
IanButterworth
added
failing
The problem was that isconst was declaring true when it was actually a back-dated (e.g. mutable) value, which confuses the runtime (e.g. show_datatype) into emitting warnings that are not warranted. Needed an updated version of Documenter, which was trying to use `isconst` in a fixed (old) world to use with `invokelatest` calls to `names` and other reflection (e.g. `setglobal!`).
|
CI is all green now. @vtjnash Is this good to merge? |
IanButterworth
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
May 28, 2025
(cherry picked from commit 58daba4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that isconst was declaring true when it was actually a back-dated (e.g. mutable) value, which confuses the two uses in the runtime (e.g. make_typealias and resolvebinding) into emitting warnings that are not warranted.