Skip to content

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 29, 2025

The problem was that isconst was declaring true when it was actually a back-dated (e.g. mutable) value, which confuses the two uses in the runtime (e.g. make_typealias and resolvebinding) into emitting warnings that are not warranted.

@vtjnash vtjnash added the backport 1.12 Change should be backported to release-1.12 label Apr 29, 2025
@vtjnash vtjnash mentioned this pull request Apr 29, 2025
3 tasks
@vtjnash
Copy link
Member Author

vtjnash commented Apr 29, 2025

Failing due a Documenter bug now correctly exposed by this fix (JuliaDocs/Documenter.jl#2693)

@KristofferC KristofferC mentioned this pull request Apr 29, 2025
53 tasks
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 9, 2025
@oscardssmith oscardssmith added merge me PR is reviewed. Merge when all tests are passing and removed merge me PR is reviewed. Merge when all tests are passing labels May 9, 2025
@KristofferC KristofferC mentioned this pull request May 9, 2025
58 tasks
@vtjnash
Copy link
Member Author

vtjnash commented May 9, 2025

Now we hit a different Documenter bug, introduced in the latest minor release (https://github.com/JuliaDocs/Documenter.jl/pull/2676/files#r2082477911)

@IanButterworth IanButterworth added failing CI is failing. Needs attention. No need to re-run CI. and removed failing CI is failing. Needs attention. No need to re-run CI. merge me PR is reviewed. Merge when all tests are passing labels May 10, 2025
The problem was that isconst was declaring true when it was actually a
back-dated (e.g. mutable) value, which confuses the runtime (e.g.
show_datatype) into emitting warnings that are not warranted.

Needed an updated version of Documenter, which was trying to use
`isconst` in a fixed (old) world to use with `invokelatest` calls to
`names` and other reflection (e.g. `setglobal!`).
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 13, 2025
@DilumAluthge
Copy link
Member

CI is all green now.

@vtjnash Is this good to merge?

@IanButterworth IanButterworth merged commit 58daba4 into master May 14, 2025
8 checks passed
@IanButterworth IanButterworth deleted the jn/57969 branch May 14, 2025 14:06
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label May 14, 2025
KristofferC pushed a commit that referenced this pull request May 28, 2025
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants