Skip to content

Conversation

topolarity
Copy link
Member

The juliac-buildscript is quite aggressive in how it modifies type printing, so caching the pre-buildscript world like this allows us to print stacktraces in their usual fidelity.

Before:

 [1] get_size_dict!(ne::StaticNestedEinsum{?, ?}, xs::Any, size_info::Dict{Char, Int64})
   @ OMEinsum ~/.julia/dev/OMEinsum/src/einsequence.jl:269
 ...

After:

 [1] get_size_dict!(ne::StaticNestedEinsum{nothing, ('j','k','l')}, xs::Any, size_info::Dict{Char, Int64})
   @ OMEinsum ~/.julia/dev/OMEinsum/src/einsequence.jl:269
 ...

The `juliac-buildscript` is quite aggressive in how it modifies type
printing, so caching the pre-buildscript world like this allows us
to print stacktraces in their usual fidelity.

Before:
```
 [1] get_size_dict!(ne::StaticNestedEinsum{Char, ?, ?}, xs::Any, size_info::Dict{Char, Int64})
   @ OMEinsum ~/.julia/dev/OMEinsum/src/einsequence.jl:269
 ...
```

After:
```
 [1] get_size_dict!(ne::StaticNestedEinsum{Char, nothing, ('j','k','l')}, xs::Any, size_info::Dict{Char, Int64})
   @ OMEinsum ~/.julia/dev/OMEinsum/src/einsequence.jl:269
 ...
```
@topolarity topolarity requested a review from JeffBezanson May 13, 2025 16:58
@topolarity topolarity added trimming Issues with trimming functionality or PR's relevant to its performance/functionality backport 1.12 Change should be backported to release-1.12 labels May 13, 2025
@topolarity topolarity merged commit ee47bd4 into JuliaLang:master May 13, 2025
9 checks passed
@KristofferC KristofferC mentioned this pull request May 20, 2025
58 tasks
@KristofferC KristofferC mentioned this pull request Jun 6, 2025
60 tasks
@topolarity topolarity removed the backport 1.12 Change should be backported to release-1.12 label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trimming Issues with trimming functionality or PR's relevant to its performance/functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants