Skip to content

[REPL] fix type confusion resulting in nonsensical errors #58414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[REPL] fix type confusion resulting in nonsensical errors #58414

merged 1 commit into from
May 15, 2025

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented May 14, 2025

Fix #58373

@vtjnash vtjnash requested a review from IanButterworth May 14, 2025 19:44
@vtjnash vtjnash added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels May 14, 2025
@IanButterworth IanButterworth removed the backport 1.10 Change should be backported to the 1.10 release label May 14, 2025
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 14, 2025
@IanButterworth IanButterworth merged commit a87b056 into master May 15, 2025
12 checks passed
@IanButterworth IanButterworth deleted the jn/REPL-backend-type-confusion branch May 15, 2025 02:54
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label May 15, 2025
KristofferC pushed a commit that referenced this pull request May 20, 2025
@vtjnash @KristofferC
[REPL] fix type confusion resulting in nonsensical errors (#58414)
c585f7e 
(cherry picked from commit a87b056)
@KristofferC KristofferC mentioned this pull request May 20, 2025
Merged
58 tasks
@serenity4 serenity4 mentioned this pull request May 20, 2025
Merged
@digital-carver digital-carver mentioned this pull request Jun 3, 2025
Merged
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Jun 4, 2025
KristofferC pushed a commit that referenced this pull request Jun 4, 2025
@vtjnash
[REPL] fix type confusion resulting in nonsensical errors (#58414)
0aac5db 
(cherry picked from commit a87b056)
@KristofferC KristofferC mentioned this pull request Jun 4, 2025
Merged
71 tasks
@ronisbr
Copy link
Member

ronisbr commented Jul 11, 2025

This PR broke TerminalPager.jl in v1.11.6 (see ronisbr/TerminalPager.jl#46). The problem is that the function eval_with_backend was renamed to eval_on_backend. The fix is pretty easy so there is no big problem. However, I want to ask:

  1. Isn't this consider a breaking change?
  2. If not, maybe eval_with_backend is supposed to be internal. In this case, what is the correct way to evaluating expressions when we are creating a new REPL mode?

ronisbr added a commit to ronisbr/TerminalPager.jl that referenced this pull request Jul 11, 2025
@ronisbr
🐛 Fix REPL interface changed in Julia v1.11.6
f987b62 
The REPL interface to evaluate commands was changed in v1.11.6. For more
information see:

    JuliaLang/julia#58414

Closes #46
ronisbr added a commit to ronisbr/TerminalPager.jl that referenced this pull request Jul 11, 2025
@ronisbr
🐛 Fix REPL interface changed in Julia v1.11.6
7705c9b 
The REPL interface to evaluate commands was changed in v1.11.6. For more
information see:

    JuliaLang/julia#58414

Closes #46
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pkg commands fail if the REPL package has been loaded prior to it
5 participants
@vtjnash @ronisbr @IanButterworth @giordano @KristofferC