Fix tbaa usage when storing into heap allocated immutable structs #58483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanosoldier |
topolarity
requested changes
May 21, 2025
topolarity
reviewed
May 21, 2025
gbaraldi
changed the title
gbaraldi
added
backport 1.11
topolarity
approved these changes
May 21, 2025
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58470. In #54604 this was half fixed but at that point I was already skeptical of the union selector being part of stack, where it's actually part of a value.
This creates a immutunionselbyte tbaa and a mut version.