make typejoin nothrow #58578
Merged
make typejoin nothrow #58578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
merge me
nsajko
reviewed
May 31, 2025
Comment on lines
+32
to
+35
| elseif a === b | ||
| return a | ||
| elseif !isa(a, Type) || !isa(b, Type) | ||
| return Any |
There was a problem hiding this comment.
Is it intentional that typejoin(3, 3, 3) returns 3, instead of Any?
There was a problem hiding this comment.
These seem a bit inconsistent, I guess:
julia> typejoin(3, 3, 3)
3
julia> typejoin(3, 3, 3.0)
Any
|
@vtjnash Just confirmed with v1.12-rc0 that the fix works - thanks a lot for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50985
(I messed up my github fu, so this is a new PR, identical to the old one)