juliac: apply buildscript modifications after user code
#59297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modifications to the MethodTable should be performed at the "link-stage", after all user top-level code has executed. This should be closer to the upcoming 1.13 pipeline, which will move all top-level user code to its standard package execution context. This also makes any user-provided functionality for type printing available to the `TrimVerifier`. Resolves JuliaLang#59280.
topolarity
added
backport 1.12
|
It's a little unfortunate that we can't use a sysimage with trimming patches already applied to save time. It's ok for now, I just hope the patch files don't grow too much or it's going to drag compile time. |
vtjnash
approved these changes
Aug 15, 2025
If they grow too much, we'd have the opposite problem of creating a diverging code base that's not fully-functional, so either way I think we need to endeavor to shrink these as much as we can. |
38 tasks
topolarity
added a commit
that referenced
this pull request
Aug 18, 2025
These modifications to the MethodTable should be performed at the "link-stage", after all user top-level code has executed. This should be closer to the upcoming 1.13 pipeline, which will move all top-level user code to its standard package execution context. This also makes any user-provided functionality for type printing available to the `TrimVerifier`. Resolves #59280.
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Sep 5, 2025
These modifications to the MethodTable should be performed at the "link-stage", after all user top-level code has executed. This should be closer to the upcoming 1.13 pipeline, which will move all top-level user code to its standard package execution context. This also makes any user-provided functionality for type printing available to the `TrimVerifier`. Resolves #59280.
KristofferC
pushed a commit
that referenced
this pull request
Sep 15, 2025
These modifications to the MethodTable should be performed at the "link-stage", after all user top-level code has executed. This should be closer to the upcoming 1.13 pipeline, which will move all top-level user code to its standard package execution context. This also makes any user-provided functionality for type printing available to the `TrimVerifier`. Resolves #59280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications to the MethodTable should be performed at the "link-stage", after all user top-level code has executed. This should be closer to the upcoming 1.13 pipeline, which will move all top-level user code to its standard package execution context.
This also makes any user-provided functionality for type printing available to the
TrimVerifier.Resolves #59280.