Type for ode4 and ode_ms and parameters for RHS #597
Conversation
|
While extra parameters are MATLAB compatible, I'd prefer we don't pollute all the ODE functions with that. You can always construct an anonymous function as in |
|
Yes, that seems reasonable. But: calling |
|
Removed parameters again. Using the input type for temp variables is still a good idea though |
|
Yep, agreed. I need to do the same in the WIP Rosenbrock solver (we really need a stiff system solver), but I need to figure out where I've messed up the algorithm first. |
|
For an implicit solver: Is there a newton method in julia yet? Or how do you solve nonlinear equations? How do you evaluate the derivative of F? |
|
I think this is a good discussion and I don't want people to miss it because they're not paying attention to the pull request, so I've continued it on julia-dev. |
Type for ode4 and ode_ms and parameters for RHS
Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: 72c7cac New commit: ae727fe Julia version: 1.13.0-DEV SparseArrays version: 1.12.0(Does not match) Bump invoked by: @ViralBShah Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@72c7cac...ae727fe ``` $ git log --oneline 72c7cac..ae727fe ae727fe Explicitly import `Matrix` and `Vector` in CHOLMOD (#601) ce852af cleanup support for Float32 and ComplexF32 (#597) ``` Co-authored-by: ViralBShah <[email protected]>
…to cdbad55 (#58724) Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: release-1.12 Julia branch: backports-release-1.12 Old commit: 72c7cac New commit: cdbad55 Julia version: 1.12.0-beta4 SparseArrays version: 1.12.0 Bump invoked by: @fredrikekre Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@72c7cac...cdbad55 ``` $ git log --oneline 72c7cac..cdbad55 cdbad55 Delete lock interface implementation from UmfpackLU (#617) 415bc9e [release-1.12] Run CI with Julia 1.12 (#635) d921308 fix libsuitesparseconfig bug f51dace Fix compat for SuiteSparse_jll fa9736c [release-1.12] Run CI with Julia 1.12 d1b0cd0 Backports for v1.12 (#624) e1817e8 Clarify pros, cons and limitations of Cholesky and LDLt (#621) b38f273 Use `libsuitesparseconfig` from JLL (#620) 66d65cc Relax `eltype` in `Diagonal` `ldiv!`/`rdiv!` (#616) 2ae8768 `ldiv!` for `Diagonal` and a sparse vector (#613) 08a15ca Replace `v == zero(v)` with `_iszero` (#610) 7ec2889 Fix `issymmetric` for matrices with empty columns (#606) f3610c0 SuiteSparse 7.10.1 wrappers and simpliefied wrapper generator process (#608) 9548149 Use `axes` instead of `1:size` (#602) ae727fe Explicitly import `Matrix` and `Vector` in CHOLMOD (#601) ce852af cleanup support for Float32 and ComplexF32 (#597) ``` Co-authored-by: fredrikekre <[email protected]>
Same problem as with ode45 before. Temp array was initialized with float, regardless of input type. Plus: I added the possibility to pass additional parameters to the RHS.