Issue with passed layout in default `cholesky!_layout` method for Symmetric matrices

[DanielVandH]

ArrayLayouts.jl/src/factorizations.jl

Lines 382 to 386 in a77697d

	function cholesky!_layout(layout, axes, A::RealHermSymComplexHerm, ::CNoPivot; check::Bool = true)
	C, info = _chol!(layout, A.data, A.uplo == 'U' ? UpperTriangular : LowerTriangular)
	check && LinearAlgebra.checkpositivedefinite(info)
	return Cholesky(C.data, A.uplo, info)
	end

Should the call to _chol! be passing MemoryLayout(A.data) instead of simply layout? Something similar is done for reversecholesky here

https://github.com/JuliaLinearAlgebra/MatrixFactorizations.jl/blob/d3f30bb62fc282e9a3873a858f2823339888e143/src/reversecholesky.jl#L113-L117

which I think is more correct?

[jishnub]

I think the idea is that layout represents the desired memory layout that has already been computed? Does this lead to issues somewhere?

[DanielVandH]

It doesn't lead to any issues that I've seen, I only noticed it while implementing the two methods elsewhere and saw the difference, so I wasn't sure if it was intentional or not.