Skip to content

Fix failing QR scaling test on v1.6 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix failing QR scaling test on v1.6 #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/test_muladd.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,11 @@ Random.seed!(0)
Q = qr(randn(5,5)).Q
b = randn(5)
B = randn(5,5)
@test Q*1.0 == ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 5, 5))
# The approx equality becomes exact on v1.10 and above,
# but that's an implementation detail.
# Below this, the LHS uses matrix broadcasting, whereas above this,
# it uses GEMQRT like the RHS
@test Q*1.0 ≈ ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 5, 5))
@test Q*b == ArrayLayouts.lmul!(Q, copy(b)) == mul(Q,b)
@test Q*B == ArrayLayouts.lmul!(Q, copy(B)) == mul(Q,B)
@test B*Q == ArrayLayouts.rmul!(copy(B), Q) == mul(B,Q)
Expand All @@ -634,7 +638,11 @@ Random.seed!(0)
Q = qr(randn(7,5)).Q
b = randn(5)
B = randn(5,5)
@test Q*1.0 == ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 7, 7))
# The approx equality becomes exact on v1.10 and above,
# but that's an implementatio detail.
# Below this, the LHS uses matrix broadcasting, whereas above this,
# it uses GEMQRT like the RHS
@test Q*1.0 ≈ ArrayLayouts.lmul!(Q, Matrix{Float64}(I, 7, 7))
@test Q*b == mul(Q,b)
@test Q*B == mul(Q,B)
@test 1.0*Q ≈ ArrayLayouts.rmul!(Matrix{Float64}(I, 7, 7), Q)
Expand Down