Use widening with addition and subtraction #12
Conversation
The original design decision was made in part to anticipate changes Julia 0.4. Unfortunately, this runs into major trouble with reductions. Since we need a package that works on 0.3, these changes seem necessary. Once someone implements widening in the reduction functions for 0.4, this change can probably be reverted.
|
I'm not sure about this --- adding two numbers of the same type generally gives that type back. Small integers are the only exceptions. |
|
Fair enough. But these are small integers in disguise. Take an image of |
|
Would you be happier if |
|
FYI, this is the only item holding up a major overhaul of Images; I'm ready to hit the merge button otherwise. I am sure you're busy doing some uber-cool stuff. If it would be easier on you, I can fork this package to some other name, and as it develops feed you pull requests to consider at your leisure. |
|
Alternatively, you can add me as a collaborator to this repository (click the "Settings" icon), let me merge my crappy PRs, and then periodically review the things I've merged and suggest improvements. |
|
That's a good idea; I added you as a collaborator. |
Use widening with addition and subtraction
|
Thanks! And sorry to be a pest. Packages tend to move pretty quickly, because their issues are generally a lot smaller than the ones affecting the entire language 😄. |
|
I'm going to tag a new release, unless you're already doing that. |
|
Ok, go ahead. I appreciate the gentle reminders; makes it easier to remember what I need to do. |
The original design decision was made in part to anticipate changes
Julia 0.4. Unfortunately, this runs into major trouble with
reductions. Since we need a package that works on 0.3, these changes
seem necessary. Once someone implements widening in the reduction functions
for 0.4, this change can probably be reverted (on the
julia 0.4-branch of this package).