Skip to content

enhance and export floattype #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2019
Merged

Conversation

johnnychen94
Copy link
Collaborator

@johnnychen94 johnnychen94 commented May 15, 2019

As a part of work in JuliaGraphics/ColorTypes.jl#121, export floattype here

For Long Integers, promote them to BigFloat since they're not representable by Float64
( representable in the sense of typemax(T) <= maxintfloat(floattype(T)))

The test is blocked by

@timholy timholy closed this May 15, 2019
@timholy timholy reopened this May 15, 2019
@timholy timholy merged commit 6b212c0 into JuliaMath:master May 15, 2019
@johnnychen94 johnnychen94 deleted the floattype branch May 16, 2019 00:39
johnnychen94 added a commit to johnnychen94/FixedPointNumbers.jl that referenced this pull request May 16, 2019
@johnnychen94
Copy link
Collaborator Author

With the following line existed, Base.float looks better than floattype. Should we un-export floattype again in favor of float? That would be a breaking change though.

float(x::Normed) = convert(floattype(x), x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants