Fix isinteger
#165
Merged
Fix isinteger
#165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #120 by means of the commonized function
trunc.This is for early feedback, so let's merge PR #163 first.Done.Obviously this is slower than the method proposed in PR #123. However, I guess that
isintegeris limitedly used, because the discovery of #120 was somewhat late and (parhaps) there was no need to rush to fix it. EvenInteger, which is the rare use case ofisinteger, is already broken (cf. #154 (comment)).The
truncis SIMD-suitable, so the slowdown is not fatal. FYI,floormay be faster but may throw errors in the cases ofFixed{Int8,8}and so on.