Add big()
and rationalize()
for FixedPoint
#186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184.
Perhaps, the users of
big
may need more accuracy than speed.(cf. #129 (comment))I want to stop using the reciprocal technique below: (Edit: done.)
FixedPointNumbers.jl/src/normed.jl
Line 247 in 7c90fb6
For large arrays, using the reciprocal technique seems to allocate more memory and slow.In the first place, it seems that the constant folding is not applied. This seems to be essentially different from the following
Float64
's case.FixedPointNumbers.jl/src/FixedPointNumbers.jl
Lines 99 to 100 in 7c90fb6