Skip to content

Update tests for show/summary #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Jul 7, 2020

I imported the tests for show/summary from PR #189 to avoid errors on the nightly build.

This adds the tests for Julia nightly build, which no longer needs the `showarg` customization.
@johnnychen94
Copy link
Collaborator

johnnychen94 commented Jul 7, 2020

Do you happen to know which commit in julialang/julia causes these changes? I muted the notification there in the last two months and can't find out a clue now.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #191 into master will increase coverage by 1.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   87.41%   88.98%   +1.57%     
==========================================
  Files           6        6              
  Lines         445      445              
==========================================
+ Hits          389      396       +7     
+ Misses         56       49       -7     
Impacted Files Coverage Δ
src/normed.jl 89.00% <0.00%> (+1.04%) ⬆️
src/fixed.jl 90.26% <0.00%> (+1.76%) ⬆️
src/FixedPointNumbers.jl 85.71% <0.00%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2a34a...2c06198. Read the comment docs.

@kimikage
Copy link
Collaborator Author

kimikage commented Jul 7, 2020

cf. the first link in #188 (comment)

@kimikage kimikage merged commit 56760f3 into JuliaMath:master Jul 7, 2020
@kimikage kimikage deleted the summary_tests branch July 7, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants