Add checked, wrapping and saturating arithmetic for rem
/mod
#230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default arithmetic for
rem
is still checked arithmetic.saturating_{rem|mod}
behaves somewhat strangely in the case of the overflow. (cf. #221 (comment))This also adds the support for 3-arg
rem
. OnlyRoundToZero
(default),RoundDown
(mod
), andRoundUp
are supported. InRoundUp
mode,rem
causesOverflowError
with unsigned (i.e.Normed
) values. Otherwise,rem
/mod
does not cause an overflow.This also adds dummy checked, wrapping and saturating
rem
for type modulus to preventMethodError
due to lexical replacement ofx % X
.This completes the implementation of the checked arithmetic. Performance tweaks without changing behavior and the rest of #185 can be carried out after the release of v0.9.0.
Closes #221