Use StableRNG in tests
#278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 7 7
Lines 782 782
=======================================
Hits 759 759
Misses 23 23 ☔ View full report in Codecov by Sentry. |
kimikage
force-pushed
the
stablerng
branch
2 times, most recently
from
6026d3b to
abe561b
Compare
|
xref: #277 (comment) |
johnnychen94
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
A harmless change to me.
It's so glad to see you well @kimikage !
Merged
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 28, 2024
This also backports the changes in PR JuliaMath#270, JuliaMath#278
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 28, 2024
This also backports the changes in PR JuliaMath#270, JuliaMath#278.
kimikage
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although reproducibility was not guaranteed, the output of
MersenneTwisterseems to have changed.Note that
rand(StableRNG(1234), T)is not a test for the generated random numbers, but for passing an RNG to the argument ofrand.On the other hand, since
StableRNGsare not part of stdlib, I added the tests for the default RNG.