Skip to content

Union() -> Union{} #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2015
Merged

Union() -> Union{} #28

merged 3 commits into from
Sep 20, 2015

Conversation

yuyichao
Copy link
Contributor

No description provided.

@yuyichao
Copy link
Contributor Author

OSX downloading error....

@timholy
Copy link
Member

timholy commented Sep 19, 2015

I restarted the build but got the same error. Note that it applies to both Linux and OSX, anything except 0.3. It's a little worrisome, since other packages don't seem to be having this problem.

@yuyichao
Copy link
Contributor Author

This seems to be the slow down caused by the coverage ...

@yuyichao
Copy link
Contributor Author

Feeding Travis with enough output get rid of the timeout ................................

@timholy
Copy link
Member

timholy commented Sep 19, 2015

That's an impressively-massive increase in runtime thanks to shutting off inlining and adding coverage testing.

Still, OK to go with it? An alternative is to try fewer cases in the test, or to leave inlining on. I haven't checked, but it seems possible that with @ihnorton's recent improvements in line numbering, we may not need this to get accurate coverage results.

timholy added a commit that referenced this pull request Sep 20, 2015
@timholy timholy merged commit 00a9989 into JuliaMath:master Sep 20, 2015
@yuyichao yuyichao deleted the 0.4-binding branch September 20, 2015 21:22
@yuyichao
Copy link
Contributor Author

Forgot to say that I've tested locally and --inline=no slow things down by about 10x.

@tkelman
Copy link
Contributor

tkelman commented Oct 2, 2015

We should write down a list somewhere of packages where enabling/disabling coverage and inlining makes such a noticeable difference to test's run time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants