Remove/rename some functionality and move operators into submodule #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused and untested.
Not used currently.
pullback has a huge potential for naming conflickts, and pullbck is more in line with pushfwd. Also simplify implementation of pullbck.
Bind has too much naming conflict potential with Base.bind. The rightarrowtail operator looks very similar to the `>=>` "fish" operator (e.g. in Haskell), which is not a monadic bind.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## mt-015 #119 +/- ##
==========================================
+ Coverage 54.05% 55.32% +1.26%
==========================================
Files 43 42 -1
Lines 1221 1184 -37
==========================================
- Hits 660 655 -5
+ Misses 561 529 -32
☔ View full report in Codecov by Sentry. |
cscherrer
reviewed
Jun 23, 2023
cscherrer
reviewed
Jun 23, 2023
cscherrer
reviewed
Jun 23, 2023
cscherrer
reviewed
Jun 23, 2023
|
|
cscherrer
reviewed
Jun 23, 2023
|
|
|
|
|
cscherrer
previously approved these changes
Jun 23, 2023
|
Removes the integral operators from MeasureBase, to be re-introduced in the submodule MeasureOperators. Also improves the likelihood documentation.
A rebase can easily be written explicitly.
To be re-introduced in sub-module MeasureOperators.
`mintegral` should be used instead to express posteriors.
To be reintroduced in submodule MeasureOperators
Absolute continuity is not really implemented yet.
Having the operators in a sub-module makes it easier for users to control whether of they want them in their namespace. Operators have a larger naming conflict potential.
Co-authored-by: Chad Scherrer <[email protected]>
Co-authored-by: Chad Scherrer <[email protected]>
|
|
|
|
|
cscherrer
dismissed
their stale review
Forgot we want to use mt-015 for staging other PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cscherrer these is the first PR to implement the somewhat breaking changes we discussed over the last days (PRs to be collected on the mt-015 branch for a MeasureBase v0.15 release sometime next week).
Most of the removed/renamed functionality is rarely used, and the operators can be accessed via
using MeasureBase.MeasureOperatorsnow, so user code should be easy to adapt.PR has a clean history, we should not squash it when we merge into mt-015, so we can keep track more easily.