Use new pipeline syntax #99
Conversation
| @@ -77,7 +86,11 @@ function install_brew() | |||
| if !isfile(joinpath(brew_prefix,"bin","otool")) | |||
| # Download/install packaged install_name_tools | |||
| try | |||
| run(`curl --location $BOTTLE_SERVER/cctools_bundle.tar.gz` |> `tar xz -C $(joinpath(brew_prefix,"bin"))`) | |||
| if use_pipeline | |||
| run(pipeline(`curl --location $BOTTLE_SERVER/cctools_bundle.tar.gz`, `tar xz -C $(joinpath(brew_prefix,"bin"))`)) | |||
There was a problem hiding this comment.
at least this one should work without the if because pipeline should be in Compat.jl - the other ones might be tuple destructuring related or something?
There was a problem hiding this comment.
I'll try using Compat and see if the fix still works
|
This smells like a real bug in base, shouldn't |
|
Ya, it should work. Maybe a mistake was introduced into Base when I'd advocate for merging this fix pretty soon anyways though to staunch the bleeding of broken Travis badges across the Julia ecosystem while that's investigated. |
|
Agreed |
|
@staticfloat can you take a look if you get a chance? though looks safe to merge sooner if you're busy |
|
xref #88 which was another bug in this piece of code |
|
As evidenced by https://travis-ci.org/JuliaWeb/MbedTLS.jl/builds/86868002l, this works on Travis. |
|
Thanks guys. :) |
|
Do we need to make a new release? |
|
Let's tag it and bag it |
|
👍 |
I'm not exactly sure why, but switching to the new-style pipeline syntax seems to fix the sporadic problems that have been coming up.
Fixes #98
xref JuliaLang/julia#13506