Skip to content

Wrap inputs in Chunk only once, or not at all #200

Open
@jpsamaroo

Description

@jpsamaroo
Member

In #199 I've fixed a "bug" where non-thunk inputs are serialized during the thunk RPC call, which is silly for large inputs. That fix assumes that inputs are large enough to wrap in a Chunk, which is not always true. It also re-wraps inputs in Chunks multiple times, which can incur extra overhead. We should make a dynamic decision whether to wrap in a Chunk, and if we wrap, wrap just once.

Activity

jpsamaroo

jpsamaroo commented on Mar 1, 2021

@jpsamaroo
MemberAuthor

Changing my mind about this after getting multi-GPU with DaggerGPU to work properly: we should always wrap inputs in a Chunk, potentially with the option to opt-out, because we don't know if the value can be serialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jpsamaroo

        Issue actions

          Wrap inputs in Chunk only once, or not at all · Issue #200 · JuliaParallel/Dagger.jl