don't sort! parents when empty in order() #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the following error which crashes the scheduler:
When parents is empty in order(), it has type Vector{Union{}}. Since Union{} is a subtype of all
Union{...any types here...} types, any package that defines Base.defalg(AbstractArray{<:Union{...any type...}})
will cause an ambiguity error. This is true even without type piracy, as the Union in the other package could
consist entirely of types defined in that package.
@jpsamaroo