Skip to content

Update darray.jl #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

raminammour
Copy link
Contributor

Closes #162 , eltype should infer correctly to the promoted part of all the types.
The original implementation assumed the same type from all the pids.

Closes JuliaParallel#162 , `eltype` should infer correctly to the promoted part of all the types.
The original implementation assumed the same type from all the `pids`.
@vchuravy
Copy link
Member

Thank you for looking into this!

So it is possible to construct a DArray where the localparts have a different eltype? I think using promote_eltype is the wrong solution for that, since the DArray now diverges from the eltype of its localparts, those are assumed to be the same in many places and I am hesitant to remove that invariant. I rather would error in this case and try very hard to not construct localparts of differing eltype.

@raminammour
Copy link
Contributor Author

Weirdly enough, this change does not break any of the tests :)

I understand if you want to preserve this invariant and want to make into an error...

@vchuravy
Copy link
Member

Thanks! But yes I would prefer this being an error.

@vchuravy
Copy link
Member

Thanks Ramin, for your work. I finished the PR in #170

@vchuravy vchuravy closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants