Dict->IdDict in exception types #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dicts use extensive specialization and this adds latency. IdDicts don't and are the go-to associative container for type-keys.
The `::Dict`, being an abstract annotation, wouldn't have been all that much help anyway.
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
- Coverage 68.03% 68.02% -0.01%
==========================================
Files 20 20
Lines 1980 2033 +53
==========================================
+ Hits 1347 1383 +36
- Misses 633 650 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM! The CI failures are unrelated (fixing it in #930) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dicts use extensive specialization and this adds latency.
IdDicts don't and are the go-to associative container
for type-keys.
This one change reduces startup time by ~0.35s: in fresh sessions, with the package already precompiled, and
--startup-file=no,masteriswhereas this branch is