[WIP] Fix cross-version: ABI tag-based precompilation cache directory #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an idea to fix cross-version capability of pyjulia. How about using Python ABI tag for separating compilation cache? In the current implementation, the cache directory uses only
sys.version_info[0]
(major version):pyjulia/julia/core.py
Lines 359 to 360 in 18d98e5
It then doesn't work when switching between, e.g., 3.6 and 3.7.
With this patch, cache directory would be:
Though I'm actually not sure if we should use the Python tag (e.g.,
cp37
) instead of the ABI tag (e.g.,cp37m
). Would PyCall.jl create different precompilation cache if it is build against, say, debug build and normal build?It is WIP until we resolve:
get_abi_tag
function? [WIP] Fix cross-version: ABI tag-based precompilation cache directory #172 (comment)But the general idea seems to be fine; I can now use pyjulia with Python 3.6 and 3.7 with this patch.