Skip to content

Simplify Experiment code after dropping RLExperiment #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

jeremiahpslewis
Copy link
Member

@jeremiahpslewis jeremiahpslewis commented Mar 13, 2024

Environment string parsing is complicated, of somewhat limited use and now much less relevant without RLExperiments
PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 23.98%. Comparing base (c821bb6) to head (5c07360).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   23.78%   23.98%   +0.19%     
==========================================
  Files         231      231              
  Lines        7983     7956      -27     
==========================================
+ Hits         1899     1908       +9     
+ Misses       6084     6048      -36     
Files Coverage Δ
src/ReinforcementLearningCore/src/core/run.jl 94.73% <50.00%> (+45.50%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@HenriDeh HenriDeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a good step in the direction of simplification.

@jeremiahpslewis jeremiahpslewis merged commit 4c935e7 into main Mar 14, 2024
@jeremiahpslewis jeremiahpslewis deleted the jpsl/experiment branch March 14, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants