Add initial dense model API and ManualDenseNLPModel implementation #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnavk23
commented
Aug 20, 2025
arnavk23
commented
- Add AbstractDenseNLPModel type and stub API
- Implement ManualDenseNLPModel with dense Jacobian/Hessian methods
- Update tests and exports for dense model support
- Remove deprecated test usage and unnecessary includes
- All tests passing
…ts in output, objective from residual
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
- Remove duplicate get_nnzh definitions in src/nlp/tools.jl to fix method overwriting warnings - Implement allocation-free jtprod! function for mixed linear/nonlinear constraints (fixes JuliaSmoothOptimizers#384) - Use coordinate-based manual accumulation to avoid temporary allocations - All tests pass with the new implementation
- Add AbstractDenseNLPModel type and stub API - Implement ManualDenseNLPModel with dense Jacobian/Hessian methods - Update tests and exports for dense model support - Remove deprecated test usage and unnecessary includes - All tests passing
|
@tmigot please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.