Prepare for AdjointFactorization
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 79.66% 79.66%
=======================================
Files 1 1
Lines 300 300
=======================================
Hits 239 239
Misses 61 61
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Gentle bump. |
|
This is ready to go. It passes tests on my PR branch. |
|
Should I just merge and release myself? Without these changes, this packages is broken on Julia v1.10+. @Wimmerer @ViralBShah |
|
Yes, please go ahead. |
|
I didn't even see these, please go ahead. Thanks @dkarrasch |
|
Locally, tests fail on v1.10-beta1, but that looks unrelated. I'll merge this and then we take it from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the ground for JuliaLang/julia#46874.