-
Notifications
You must be signed in to change notification settings - Fork 32
update piracies code to support v1.12 changes #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reflects current status of JuliaLang/julia#58131 PR.
Is JuliaLang/julia#58131 still going into 1.12? I am asking this surprised as it is already quite late in the release cycle and that PR doesn't have a backport label. I'll give this a merge once there is a prerelease/nightly build that verifies that in indeed works in action. But for right now, all CI failed due to something with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 86.93% 86.91% -0.03%
==========================================
Files 11 11
Lines 513 512 -1
==========================================
- Hits 446 445 -1
Misses 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks! I'll re-run CI and merge this once there is a nightly version containing JuliaLang/julia#58131 (in the next two days or so). That way, this patch should already be available when 1.12.0-beta3 gets released
The current CI run uses |
(cherry picked from commit d420041)
(cherry picked from commit d420041)
Reflects current status of JuliaLang/julia#58131 PR to remove unnecessary work that is no longer viable.