Skip to content

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented May 27, 2025

Reflects current status of JuliaLang/julia#58131 PR to remove unnecessary work that is no longer viable.

@lgoettgens
Copy link
Collaborator

Is JuliaLang/julia#58131 still going into 1.12? I am asking this surprised as it is already quite late in the release cycle and that PR doesn't have a backport label.

I'll give this a merge once there is a prerelease/nightly build that verifies that in indeed works in action.

But for right now, all CI failed due to something with Base.visit.

@lgoettgens lgoettgens added test: piracy backport-0.8 Should be backported to a 0.8.x release changelog: missing labels May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (07be761) to head (cb24a6d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   86.93%   86.91%   -0.03%     
==========================================
  Files          11       11              
  Lines         513      512       -1     
==========================================
- Hits          446      445       -1     
  Misses         67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens self-requested a review May 28, 2025 14:02
Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! I'll re-run CI and merge this once there is a nightly version containing JuliaLang/julia#58131 (in the next two days or so). That way, this patch should already be available when 1.12.0-beta3 gets released

@lgoettgens lgoettgens merged commit d420041 into JuliaTesting:master May 28, 2025
22 of 23 checks passed
@lgoettgens
Copy link
Collaborator

The current CI run uses Julia Version 1.13.0-DEV.647 which already includes JuliaLang/julia#58131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-0.8 Should be backported to a 0.8.x release changelog: added test: piracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants