Skip to content

Factor some utilities out into a separate package #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MasonProtter opened this issue Jan 12, 2020 · 8 comments · Fixed by #78
Closed

Factor some utilities out into a separate package #77

MasonProtter opened this issue Jan 12, 2020 · 8 comments · Fixed by #78

Comments

@MasonProtter
Copy link

It was brought to my attention that your implementation of splitdef and combinedef is preferable to the one found in MacroTools.jl. I think a separate package for those utilities and maybe a few others would be appreciated so I can depend on those instead of the entirety of Mocking.

@tk3369
Copy link

tk3369 commented Jan 13, 2020

Really? How? Perhaps better to contribute back to MacroTools?

@omus
Copy link
Member

omus commented Jan 13, 2020

Really? How? Perhaps better to contribute back to MacroTools?

The versions in this package handle more syntax than MacroTools.jl and are more performant. See
#66

I'll make a PR to MacroTools.jl with the improved version but my personal preference would be to have this functionality as a completely separate package as I'm trying to keep the dependency tree for Mocking.jl very light.

@MasonProtter
Copy link
Author

MasonProtter commented Jan 13, 2020

If it's factored into a separate package, we can just submit a PR to MacroTools asking it to depend on that package. MacroTools already has a million to dependancies (via DataStructures), so what's one more?

@oxinabox
Copy link
Member

(DataStructures.jl only has 1 dependency -- OrderedCollections.jl)

But yes,I would like this in a seperate package. Then one can use this + MLStyle instead of MacroTools for most features.

@omus
Copy link
Member

omus commented Jan 14, 2020

I'll make this as a separate package. I guess it can stay in the Invenia github org as I'm not seeing a suitable Julia org.

@omus
Copy link
Member

omus commented Jan 14, 2020

Still working on it but I've pushed some code: https://github.com/invenia/ExprTools.jl

@omus
Copy link
Member

omus commented Jan 15, 2020

ExprTools.jl is currently awaiting registration: JuliaRegistries/General#7999

@omus
Copy link
Member

omus commented Jan 20, 2020

Package is registered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants