Switch to using ExprTools.jl #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Package is now registered. I've restarted the CI |
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 89.5% 84.46% -5.04%
==========================================
Files 6 6
Lines 181 103 -78
==========================================
- Hits 162 87 -75
+ Misses 19 16 -3
Continue to review full report at Codecov.
|
omus
commented
Jan 28, 2020
oxinabox
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up in #77 the
splitdefandcombinedeffunction needed to be moved into a different package. These functions were originally inspired from the versions in MacroTools.jl but due to that package having quite a few dependencies it was thought best to move this functionality into a new package: ExprTools.jlCurrently this PR is a draft due to ExprTools.jl having not yet been registered (JuliaRegistries/General#7999)
Fixes #77 and #75