Skip to content

Adding additional methods for v1.6.0 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 20, 2025
Merged

Adding additional methods for v1.6.0 #56

merged 23 commits into from
Aug 20, 2025
+4,525 −33

Conversation

SeaBlooms
Copy link

@SeaBlooms SeaBlooms commented Aug 14, 2025 •
edited
Loading

v1.6.0

  • add Questions methods
  • add Custom File Transfer methods

@SeaBlooms SeaBlooms requested review from a team as code owners August 14, 2025 20:36
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 14, 2025
View reviewed changes
SeaBlooms and others added 6 commits August 14, 2025 14:40
@SeaBlooms @github-advanced-security
Potential fix for code scanning alert no. 115: Unused import
c9d201e 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@SeaBlooms @github-advanced-security
Potential fix for code scanning alert no. 116: Unused import
24e9fde 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@SeaBlooms @github-advanced-security
Potential fix for code scanning alert no. 113: Unused local variable
dc1dadf 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@SeaBlooms @github-advanced-security
Potential fix for code scanning alert no. 117: Unused import
a8e952f 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@SeaBlooms
Update test_create_question.py
9a93211
@SeaBlooms
Merge branch 'KNO-606' of https://github.com/JupiterOne/jupiterone-ap…
7cdaf91 
…i-client-python into KNO-606
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 15, 2025
View reviewed changes
mscottford
mscottford previously approved these changes Aug 15, 2025
View reviewed changes
Copy link

@mscottford mscottford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Well documented, clean implementation, and thorough tests.

I've got some non-blocking suggestions that came to mind while I was reading through.

@SeaBlooms
Copy link
Author

Thanks @mscottford - This PR is still in-progress, I'll be adding more methods over the next week or so

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 19, 2025
View reviewed changes
@SeaBlooms SeaBlooms requested a review from mscottford August 19, 2025 19:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 19, 2025
View reviewed changes
@SeaBlooms SeaBlooms requested a review from erincrawford August 19, 2025 19:58
bjoepfeiffer
bjoepfeiffer previously approved these changes Aug 20, 2025
View reviewed changes
@SeaBlooms SeaBlooms requested a review from bjoepfeiffer August 20, 2025 16:00
@SeaBlooms SeaBlooms merged commit 562f12b into main Aug 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoepfeiffer bjoepfeiffer bjoepfeiffer approved these changes

@mscottford mscottford Awaiting requested review from mscottford

@erincrawford erincrawford Awaiting requested review from erincrawford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeaBlooms @mscottford @bjoepfeiffer