Clean up cuTENSOR plan memory #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jutho
reviewed
Jun 30, 2025
| @@ -312,7 +312,10 @@ function plan_trace(@nospecialize(A::AbstractArray), Ainds::ModeType, | |||
| plan_pref = Ref{cutensorPlanPreference_t}() | |||
| cutensorCreatePlanPreference(handle(), plan_pref, algo, jit) | |||
|
|
|||
| return CuTensorPlan(desc[], plan_pref[]; workspacePref=workspace) | |||
| plan = CuTensorPlan(desc[], plan_pref[]; workspacePref=workspace) | |||
There was a problem hiding this comment.
So how does this work; the OperationDescriptor and PlanPreference are copied by the CuTensorPlan constructor, so the original copies need to be destroyed afterwards?
There was a problem hiding this comment.
I think they are used, and then no longer needed. To be honest, I didn’t check precisely what is going on the first time and just copied this over from the cuTENSOR implementation for reductions, so now I just adapted the changes from the PR there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve memory management by ensuring proper destruction of operation descriptors and plan preferences in the cuTENSOR plan function.
This is the equivalent of https://github.com/JuliaGPU/CUDA.jl/pull/2794/files
Fixes #211