Test conflict between pytest and flask

[bilalshaikh42]

Pytest 5.0.0 (and above?) have a conflict with flask 1.04 and below. Look at the requirements for karr_lab_build_utils and this package to diagnose.
Perhaps need to explicitly define test requirements to use a different version of flask or pytest

pytest-dev/pytest#5532

[jonrkarr]

Do you need an old version of flask?

…

On Thu, Aug 22, 2019, 6:29 PM Bilal Shaikh ***@***.***> wrote: Pytest 5.0.0 (and above?) have a conflict with flask 1.04 and below. Look at the requirements for karr_lab_build_utils and this package to diagnose. Perhaps need to explicitly define test requirements to use a different version of flask or pytest pytest-dev/pytest#5532 <pytest-dev/pytest#5532> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAVXMKO5ZX7VAM6C34MKNT3QF4HLDA5CNFSM4IOZ2O4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HG5ABSQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVXMKNXRXNNZRLFSYCMO6DQF4HLDANCNFSM4IOZ2O4A> .

[bilalshaikh42]

Apparently, this was already fixed in connexion by upgrading flask >1.04. Tests are passing locally, but not on circleci. Circle ci is using pytest 5.01 for this build, so flask must be the outdated package

spec-first/connexion#991

[jonrkarr]

In the requirements, specify the minimum flask version needed. This should make circle update flask.

…

On Thu, Aug 22, 2019, 6:44 PM Bilal Shaikh ***@***.***> wrote: Apparently, this was already fixed in connexion by upgrading flask >1.04. Tests are passing locally, but not on circleci. Circle ci is using pytest 5.01 for this build, so flask must be the outdated package spec-first/connexion#991 <spec-first/connexion#991> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAVXMKPQ2HCECKXOFT7O2R3QF4JDZA5CNFSM4IOZ2O4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD46TOSQ#issuecomment-524105546>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVXMKOK6J6UNLRZKFJVABTQF4JDZANCNFSM4IOZ2O4A> .

[bilalshaikh42]

While the current connexion package requires flask > 1.04 it seems that the circle build somehow thinks it only needs >0.10. Adding the explicit requirement does make circle update, but it might be worth looking into why it didn't happen automatically.
From circle:
Requirement already satisfied, skipping upgrade: connexion in /usr/local/lib/python3.6/site-packages (from datanator-rest-api==0.0.1) (2.3.0) #this should require flask>=1.0.4

Requirement already satisfied, skipping upgrade: flask>=0.10.1 in /usr/local/lib/python3.6/site-packages (from connexion->datanator-rest-api==0.0.1) (1.0.2) #however, pip believes it only needs> 0.10.1 which was changed in the connexion issue refrences above

[bilalshaikh42]

While the issue with flask does resolve with the explicit requirement, there are now other collection failures. I'll keep experimenting

[jonrkarr]

Could be related to the order of operations. When I've had difficulty with package versions, I've updated the docker image.

…

On Thu, Aug 22, 2019, 7:03 PM Bilal Shaikh ***@***.***> wrote: While the issue with flask does resolve with the explicit requirement, there are now other collection failures. I'll keep experimenting — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAVXMKMXT5ESWNLSAEKZTZTQF4LLDA5CNFSM4IOZ2O4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD46UPVA#issuecomment-524109780>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVXMKKZ7IHCHRTPZEEWX4LQF4LLDANCNFSM4IOZ2O4A> .

[bilalshaikh42]

Adding flask package version to test requirement file before requirements that use flask a s sub dependency resolved issue.