Upgrade to Scala 3.3.1. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`inline` parameters can be evaluated several times, and therefore are not stable paths, so they cannot be used in path-dependent types. Checking this was fixed in Scala 3.3.0. See scala/scala3#15511
Scala 3.3.0 does not allow the `extends` clause of a class to refer to constructor parameters. It was shown to be unsound. See scala/scala3#16270 However, we can depend on paths that enclose the class definition. So we introduce a container class `TreeMaps` that takes the `q: Q` as parameter, and move the classes that extend `q.reflect.TreeMap` inside that container.
We cannot use 3.3.0 because of scala/scala3#16706 but that issue is fixed in 3.3.1.
This addresses an infinite loop warning.
The error was:
Exception occurred while executing macro expansion.
scala.quoted.runtime.impl.ScopeException:
Expression created in a splice was used outside of that splice.
Created in: .../inlineHkdGeneric.scala:575 at column 24
Used in: .../inlineHkdGeneric.scala:564 at column 30
Expr: i
Creation stack:
.../inlineHkdGeneric.scala:575 at column 24
.../inlineHkdGeneric.scala:761 at column 7
Use stack:
.../inlineHkdGeneric.scala:564 at column 30
.../inlineHkdGeneric.scala:761 at column 7
Hint: A common reason for this to happen is when a `def` that creates a `'{...}`
captures an outer instance of `Quotes`. If this `def` is called in a splice
it will not track the `Quotes` provided by that particular splice.
To fix it add a `given Quotes` to this `def`.
sjrd
force-pushed
the
scala-3.3.1-RC4
branch
from
b4c3043 to
d08a47d
Compare
|
Updated for 3.3.1 final, now that it is released. |
|
Sorry for forgetting about this |
anatoliykmetyuk
added a commit
to scala/scala3
that referenced
this pull request
Sep 7, 2023
~~The second commit corresponds to [a PR upstream](Katrix/perspective#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit is best reviewed ignoring whitespace change.