-
Notifications
You must be signed in to change notification settings - Fork 30
[MERGED] Rework, breaking changes #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MERGED] Rework, breaking changes #29
Conversation
added h2 tag to every pages/*/index && updated README.md etc...
This pretty much covers issues 16, 23 and 22 |
Woah, that's a huge PR. 301 files, and it covers 3 issues. Thanks a lot! I will review and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really good. But what happened to the main quiz.. I see that the main quiz just takes you to Browsers Quiz.
Main Quiz Preview: https://quiz.kendalldoescoding.tech/game/
Add a cute little favicon to all html files
I cannot see the favicon that you've said you added in Proposed Changes.
Awaiting your reply on this @Hachikoi-the-creator |
I tried it on your deployment and sent me to browsers quiz, so I assumed that's how it worked, will check and add it! |
oh if I do another PR just adds itself to this (context)? nice |
coz you updated the stuff to the same branch!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But, would it be possible to include the question number on the side of "Question text" like in the original website?
Got into a bootcamp and finally got some free time, it was easier than expected lol |
what about adding mongoDB? and updating the highscores to show top5 of every category? that'd be sick! |
can you make a issue (feature request) on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, but please resolve conflicts to go to merge. @Hachikoi-the-creator
I tried leaving
|
I can't even merge from command line :( |
I managed to commit the PR, but I couldn't make it so you committed all the files :(! |
Hey @Hachikoi-the-creator , Sorry that it took almost a month for me to merge this. I was really busy. I don't know how to thank you. This is such a amazing Pull Request, that I've needed to do from a long time. Thanks for putting in so much hard work!! |
Sider has detected 3 errors on analyzing the commit a0188ed.
If the errors persist even after retrying, the following actions may resolve them:
If you still have problems, feel free to ask us via chat. 💬 You can turn off such notifications if unnecessary. |
bymistake #29 removed the github directory. This commit adds it back.
nono thanks for making the merge, I was really overwhelmed working whit C and needed something refreshing, this was so fun to do! |
@Hachikoi-the-creator I just included your name in README.md for the big changes you did to this project. I'm going to begin work/adding more quizzes, etc on this project soon! |
Related Issue/Addition to code
Fixes #16
Fixes #22
Fixes #23
Fixes #30
Type of change
live branch
Proposed Changes
Additional Info
Checklist:
Dev notes
Even tho it was a lot of work, I truly loved how consistent you where in the styling and classes naming, really makes the difference!