Skip to content

Error should give path to the file #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Error should give path to the file #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a7b34
Error should give path to the file
Aug 26, 2019
deeb84d
Change test to ignore file path in error
Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Converter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class Converter extends Transform implements PromiseLike<any[]> {
const rs = fs.createReadStream(filePath, options);
rs.pipe(this);
} else {
this.emit('error', new Error("File does not exist. Check to make sure the file path to your csv is correct."));
this.emit('error', new Error("File " + filePath + " does not exist. Check to make sure the file path to your csv is correct."));
}
});
return this;
Expand Down
2 changes: 1 addition & 1 deletion test/testCSVConverter3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe("testCSVConverter3", function () {
it("emit file not exists error when try to open a non-exists file", function () {
let called = false;
const cb = sb.spy((err) => {
assert(err.toString().indexOf("File does not exist") > -1);
assert(err.toString().indexOf("does not exist") > -1);
});
return csv()
.fromFile("somefile")
Expand Down