Skip to content

Conversation

catrielmuller
Copy link
Contributor

@catrielmuller catrielmuller commented Aug 15, 2025

Context

This PR implements the "Inline assist seq implementation" which appears to be a significant overhaul of the ghost suggestion system for inline code assistance. The changes focus on improving model compatibility and performance for inline code completion.

Implementation

  • Restructured the GhostStrategy to use a new XML-based search-and-replace format instead of JSON
  • Enhanced the GhostSuggestions system with improved operation grouping logic and closest group selection
  • Refactored decorations to display suggestions more effectively with different visual styles for edits, additions, and deletions
  • Sequential Implementation when we only display the closest suggestion and after the user accept that show the next one

Screenshots

screencast

Copy link

changeset-bot bot commented Aug 15, 2025

🦋 Changeset detected

Latest commit: a2d72ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kilo-code Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the "Inline assist seq implementation" which appears to be a significant overhaul of the ghost suggestion system for inline code assistance. The changes focus on improving model compatibility and performance for inline code completion.

Key changes include:

  • Restructured the GhostStrategy to use a new XML-based search-and-replace format instead of JSON
  • Enhanced the GhostSuggestions system with improved operation grouping logic and closest group selection
  • Refactored decorations to display suggestions more effectively with different visual styles for edits, additions, and deletions

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
src/services/ghost/types.ts Added oldLine and newLine properties to GhostSuggestionEditOperation interface
src/services/ghost/__tests__/GhostSuggestions.test.ts New comprehensive test suite for suggestion grouping and selection logic
src/services/ghost/__tests__/GhostStrategy.test.ts New test file focusing on the updated GhostStrategy methods
src/services/ghost/__tests__/GhostStrategy.spec.ts Updated existing tests to use real structuredPatch and new XML format
src/services/ghost/GhostSuggestions.ts Major refactor with new grouping algorithms and closest group selection
src/services/ghost/GhostStrategy.ts Complete rewrite to use XML search-and-replace format with improved prompt engineering
src/services/ghost/GhostProvider.ts Updated to use new cursor management and selection logic
src/services/ghost/GhostModel.ts Added debug logging and model information access
src/services/ghost/GhostDecorations.ts Redesigned decoration system with group-based rendering
src/services/ghost/GhostCursor.ts New file for managing cursor positioning after applying suggestions
.changeset/beige-sheep-post.md Changeset documenting the improvements

@catrielmuller catrielmuller marked this pull request as ready for review August 15, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant