Fix Gemini CLI integration and MCP server addition #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new public method to the class to allow for the programmatic addition of MCP servers. This resolves a runtime error in the that was incorrectly attempting to call a private method. The new method: - Accepts a server name, a configuration object, and the source (global or project). - Validates the provided configuration to ensure it includes a . - Adds the new server to the appropriate settings file (). - Leverages the existing method to properly load and connect to the new server. - Includes robust error handling to provide clear feedback to the user. This change ensures that MCP servers can be added dynamically from the webview without causing errors, improving the stability and usability of the MCP server management interface.
|
|
@Qiiks thanks for your PR, can you make a separate one for the Gemini CLI Fix? I think we'll be able to review/merge that one faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following fixes:
addServermethod to theMcpHubclass.