Skip to content

feat(balancer): support upstream host_header and router preserve_host config for stream tls proxy #11244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 28, 2023
Merged

feat(balancer): support upstream host_header and router preserve_host config for stream tls proxy #11244

merged 24 commits into from
Jul 28, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Jul 18, 2023 •
edited
Loading

Summary

  1. support upstream host_header config for stream tls proxy, so that TLS upstream sni can be configured by host_header.
  2. support route preserve_host config for stream tls proxy.

Checklist

Issue reference

https://konghq.atlassian.net/browse/FTI-5234

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 18, 2023
@oowl oowl changed the title feat(balancer): support upstream preserve_host and host config for stream proxy fix(balancer): support upstream preserve_host and host config for stream proxy Jul 18, 2023
@oowl oowl marked this pull request as draft July 18, 2023 08:58
@oowl oowl changed the title fix(balancer): support upstream preserve_host and host config for stream proxy fix(balancer): support upstream host_header config for stream tls proxy Jul 25, 2023
@oowl oowl marked this pull request as ready for review July 26, 2023 05:56
@oowl oowl added this to the 3.4.0 milestone Jul 26, 2023
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@oowl oowl force-pushed the fix/stream-upstream-tls-sni branch 3 times, most recently from 66516f8 to f202d2c Compare July 27, 2023 07:31
@oowl oowl changed the title fix(balancer): support upstream host_header config for stream tls proxy fix(balancer): support upstream host_header and router preserve_host config for stream tls proxy Jul 27, 2023
@oowl oowl changed the title fix(balancer): support upstream host_header and router preserve_host config for stream tls proxy feat(balancer): support upstream host_header and router preserve_host config for stream tls proxy Jul 27, 2023
@RobSerafini RobSerafini requested review from locao and removed request for locao July 27, 2023 16:00
StarlightIbuki
StarlightIbuki approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Except for the naming of the config.

@oowl oowl force-pushed the fix/stream-upstream-tls-sni branch from 8097c7e to 2f56153 Compare July 28, 2023 08:15
@oowl oowl force-pushed the fix/stream-upstream-tls-sni branch from 2f56153 to 2ab6eda Compare July 28, 2023 08:43
oowl added 18 commits July 28, 2023 16:43
@oowl
feat(balancer): fix code
4f61af0 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
f2e1dc4 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
7f843dd 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
0fffdd8 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
27f5bdb 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
1da3ff8 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
dbac925 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
648faf1 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
4f7387e 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
4b81149 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
325afea 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
7e6c698 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
cba33d0 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
7ba9833 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
c996cee 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
2480d48 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
a6ee39c 
Signed-off-by: owl <[email protected]>
@oowl
feat(balancer): fix code
0bc10f2 
Signed-off-by: owl <[email protected]>
@oowl oowl force-pushed the fix/stream-upstream-tls-sni branch from 2ab6eda to 0bc10f2 Compare July 28, 2023 08:43
@kikito kikito merged commit 03d24bc into master Jul 28, 2023
@kikito kikito deleted the fix/stream-upstream-tls-sni branch July 28, 2023 16:59
@team-gateway-bot team-gateway-bot mentioned this pull request Jul 28, 2023
Merged
team-gateway-bot pushed a commit that referenced this pull request Jul 28, 2023
@oowl @github-actions
feat(balancer): support upstream host_header and router preserve_host…
f5b2529 
… config for stream tls proxy (#11244)

(cherry picked from commit 03d24bc)
flrgh pushed a commit that referenced this pull request Jul 29, 2023
@team-gateway-bot @oowl
feat(balancer): support upstream host_header and router preserve_host…
6e86cd4 
… config for stream tls proxy (#11244)

(cherry picked from commit 03d24bc)

Co-authored-by: oowl <[email protected]>
@kikito kikito mentioned this pull request Aug 9, 2023
Merged
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmgc windmgc windmgc left review comments

@ms2008 ms2008 ms2008 left review comments

@kikito kikito kikito approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@gruceo gruceo gruceo approved these changes

Assignees

@oowl oowl

Labels
changelog core/balancer core/proxy size/L
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oowl @CLAassistant @kikito @windmgc @ms2008 @StarlightIbuki @gruceo