Skip to content

Compatibility with ggplot2 3.6.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Compatibility with ggplot2 3.6.0 #23

merged 1 commit into from
Jan 31, 2025

Conversation

teunbrand
Copy link
Contributor

Hi there,

Apologies for not posting an issue first.
The ggplot2 package is planning an update for around May 2025 and a reverse dependency test identified a problem with the RKorAPClient package.
The details are explained in tidyverse/ggplot2#6290, but essentially ggplot2 doesn't populate the plot$labels field before plot building anymore, which violates some test assumptions in this package.

This PR changes the tests to be compatible with both versions of ggplot2.
You can test the changes yourself with the development version of ggplot2 (pak::pak("tidyverse/ggplot2"))

Best,
Teun

@kupietz
Copy link
Member

kupietz commented Jan 31, 2025

Hi there,

Apologies for not posting an issue first. The ggplot2 package is planning an update for around May 2025 and a reverse dependency test identified a problem with the RKorAPClient package. The details are explained in tidyverse/ggplot2#6290, but essentially ggplot2 doesn't populate the plot$labels field before plot building anymore, which violates some test assumptions in this package.

This PR changes the tests to be compatible with both versions of ggplot2. You can test the changes yourself with the development version of ggplot2 (pak::pak("tidyverse/ggplot2"))

Best, Teun

Thank you so much, @teunbrand, for taking care of this and even providing a pull request! I’ll make sure to release a new version of RKorAPClient soon.

All the best,
Marc

@kupietz kupietz merged commit 37e07e8 into KorAP:master Jan 31, 2025
6 checks passed
@teunbrand
Copy link
Contributor Author

Thank you for the swift response!

@teunbrand teunbrand deleted the ggplot2_360 branch January 31, 2025 14:40
@teunbrand teunbrand restored the ggplot2_360 branch January 31, 2025 14:40
@teunbrand teunbrand deleted the ggplot2_360 branch January 31, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants