Correctly handle disappeared native/web targets #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
approved these changes
Jun 5, 2024
src/functionalTest/kotlin/kotlinx/validation/test/KlibVerificationTests.kt
Show resolved
Hide resolved
fzhinkin
force-pushed
the
make-tasks-public
branch
from
2b7b900 to
4de527a
Compare
fzhinkin
force-pushed
the
make-tasks-public
branch
from
8b0f562 to
d8271ab
Compare
fzhinkin
force-pushed
the
234-correctly-handle-disappeared-targets
branch
from
130eeff to
3ed0bf9
Compare
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
* Improve exception message * Added a test reproducing the issue from Kotlin/binary-compatibility-validator#234 (p. 1 & 2) * Removed native targets should trigger validation failure Fixes Kotlin/binary-compatibility-validator#234 Pull request Kotlin/binary-compatibility-validator#236
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
* Improve exception message * Added a test reproducing the issue from Kotlin/binary-compatibility-validator#234 (p. 1 & 2) * Removed native targets should trigger validation failure Fixes Kotlin/binary-compatibility-validator#234 Pull request Kotlin/binary-compatibility-validator#236
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
* Improve exception message * Added a test reproducing the issue from Kotlin/binary-compatibility-validator#234 (p. 1 & 2) * Removed native targets should trigger validation failure Fixes Kotlin/binary-compatibility-validator#234 Pull request Kotlin/binary-compatibility-validator#236
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
* Improve exception message * Added a test reproducing the issue from Kotlin/binary-compatibility-validator#234 (p. 1 & 2) * Removed native targets should trigger validation failure Fixes Kotlin/binary-compatibility-validator#234 Pull request Kotlin/binary-compatibility-validator#236 Moved from Kotlin/binary-compatibility-validator@db8c335
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
* Improve exception message * Added a test reproducing the issue from Kotlin/binary-compatibility-validator#234 (p. 1 & 2) * Removed native targets should trigger validation failure Fixes Kotlin/binary-compatibility-validator#234 Pull request Kotlin/binary-compatibility-validator#236 Moved from Kotlin/binary-compatibility-validator@db8c335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle cases when a dump containing declarations for Apple targets is validated on hosts not supporting these targets, BCV filters out a golden dump committed to the repo.
Unfortunately, the filtration logic was invalid. Instead of filtering out targets known to be unsupported, the corresponding task was filtering out everything except supported targets. If a target was removed from the config, it could no longer make it to a set of supported/enabled targets, and the aforementioned task would filter it out.
Fix changes the filtration logic only to remove targets that were defined in a project but are known to be unsupported.
Fixes #234