Skip to content

Conversation

fzhinkin
Copy link
Collaborator

@fzhinkin fzhinkin commented Jun 6, 2024

Recently, I was running BCV tests on hosts with only recent Java installed, and automatic toolchain provisioning could made my life much easier.

@fzhinkin fzhinkin requested a review from shanshin June 6, 2024 14:51
@fzhinkin fzhinkin assigned fzhinkin and unassigned fzhinkin Jun 6, 2024
@JakeWharton
Copy link

Why use a toolchain when any modern JDK can cross-compile to Java 8 with faster compilation speeds and bytecode generation bugfixes using the --release flag?

@fzhinkin
Copy link
Collaborator Author

fzhinkin commented Jun 6, 2024

Why use a toolchain when any modern JDK can cross-compile to Java 8 with faster compilation speeds and bytecode generation bugfixes using the --release flag?

@JakeWharton, it's just more convenient compared to explicitly specifying the target for all kotlin- and java-tasks.

@shanshin
Copy link
Contributor

@JakeWharton, I would also prefer to use flags, however, not all of our agents have JDK installed on which the flag -Xjdk-release works.

@fzhinkin, could you clarify a little bit why we are limiting the JDK version? To make the BCV plugin work if Gradle runs on older JVMs?

@fzhinkin
Copy link
Collaborator Author

@shanshin, yes, the version is limited for Gradle compatibility reasons (it works with Java >= 8).

@fzhinkin
Copy link
Collaborator Author

At the same time, according to our Readme, Java >= 11 is required to use BCV :)

@fzhinkin fzhinkin merged commit 33a495b into develop Jun 24, 2024
@fzhinkin fzhinkin deleted the setup-jvm-toolchain-resolver branch June 24, 2024 15:48
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
…ains

* Use foojay-resolver-convention to resolve JVM toolchains
* Remove no longer needed java toolchain setup
Pull request Kotlin/binary-compatibility-validator#238
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
…ains

* Use foojay-resolver-convention to resolve JVM toolchains
* Remove no longer needed java toolchain setup
Pull request Kotlin/binary-compatibility-validator#238
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
…ains

* Use foojay-resolver-convention to resolve JVM toolchains
* Remove no longer needed java toolchain setup
Pull request Kotlin/binary-compatibility-validator#238
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
…ains

* Use foojay-resolver-convention to resolve JVM toolchains
* Remove no longer needed java toolchain setup
Pull request Kotlin/binary-compatibility-validator#238

Moved from Kotlin/binary-compatibility-validator@33a495b
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this pull request Jan 3, 2025
…ains

* Use foojay-resolver-convention to resolve JVM toolchains
* Remove no longer needed java toolchain setup
Pull request Kotlin/binary-compatibility-validator#238

Moved from Kotlin/binary-compatibility-validator@33a495b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants