explode docs and tests
#1291
Merged
explode docs and tests
#1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
approved these changes
Jul 3, 2025
| selector: ColumnsSelector<T, *> = defaultExplodeColumns, | ||
| ): DataFrame<T> = toDataFrame().explode(dropEmpty, selector) | ||
|
|
||
| columns: ColumnsSelector<T, *> = defaultExplodeColumns, |
There was a problem hiding this comment.
While renaming an argument might not break binary compatibility, it will break source compatibility in some cases. However, as it's almost never named explicitly I think we can let it slide :) This Kotlinconf talk mentions something about compatibility levels if you're interested in them https://youtu.be/JKLqQiYh8GQ?si=gF5LkFq5vAPAxSIG&t=358
|
|
||
| /** | ||
| * Splits list-like values in the specified [\columns] and spreads them vertically — | ||
| * that is, adds a separate row for each element (one value per row). |
| * If no [\columns] are specified, all columns (at any depth) containing | ||
| * [List] or [DataFrame] values will be exploded. | ||
| * | ||
| * If [dropEmpty] is `true`, rows with empty lists or DataFrames will be removed. |
There was a problem hiding this comment.
Either link to [DataFrame] if you want to specifically mention an instance of the class, or write "dataframes"
| * ### This `explode` overload | ||
| */ | ||
| @ExcludeFromSources | ||
| internal interface ExplodeDocs |
|
|
||
| /** | ||
| * Splits list-like values in the specified [\columns] of this [DataRow] and spreads them vertically — | ||
| * that is, adds a separate row for each element (one value per row) |
Jolanrensen
reviewed
Jul 4, 2025
|
|
||
| override fun Arguments.interpret(): PluginDataFrameSchema { | ||
| val columns = selector ?: object : ColumnsResolver { | ||
| val columns = columns ?: object : ColumnsResolver { |
There was a problem hiding this comment.
@AndreiKingsley @koperagen make sure to sync this with the actual compiler plugin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1277