Skip to content

DateTimeFormatter #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kprakash2 opened this issue Jul 20, 2021 · 1 comment
Closed

DateTimeFormatter #133

kprakash2 opened this issue Jul 20, 2021 · 1 comment
Labels
formatters Related to parsing and formatting

Comments

@kprakash2
Copy link

Hi all,

I'm working on adding support for DateTimeFormatter, it seems pretty straight forward for JVM and JS platforms and I'll open a PR soon for these two platforms. However, I haven't done much native stuff and was wondering if anyone have any ideas or thoughts for native implementation.

I noticed currently all of the native code is implemented around ISO_OFFSET_DATE_TIME format, any ideas or thoughts on how to extend it to support other formats?

@dkhalanskyjb dkhalanskyjb added the formatters Related to parsing and formatting label Nov 22, 2021
@GautierLouis
Copy link

Hello @kprakash-dev ,

I'm also creating a DateTimeFormatter (+ZonedDateTime) on my own

You can take a look for the implementation of Apple targets.

ISO_OFFSET_DATE_TIME can be easily translated as string pattern such as "YYYY-MM-dd'T'HH:mm:ssXXXX" (source: https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html#ISO_OFFSET_DATE_TIME)

Louis

dkhalanskyjb added a commit that referenced this issue Feb 20, 2024
Fixes #39
Fixes #58
Fixes #90
Fixes #128
Fixes #133
Fixes #139
Fixes #211
Fixes #240
Fixes #83
Fixes #276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatters Related to parsing and formatting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@kprakash2 @GautierLouis @dkhalanskyjb and others