Implement parsing and formatting days-of-year #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
reviewed
Aug 2, 2024
|
|
||
| override fun hashCode(): Int = | ||
| year.hashCode() * 31 + monthNumber.hashCode() * 31 + dayOfMonth.hashCode() * 31 + isoDayOfWeek.hashCode() * 31 | ||
| year.hashCode() * 31 + monthNumber.hashCode() * 31 + dayOfMonth.hashCode() * 31 + isoDayOfWeek.hashCode() * 31 + |
There was a problem hiding this comment.
Looks like the multiplication by 31 is useless here, these hashcodes could just be all summed
There was a problem hiding this comment.
On the other hand, a list-like data structure (e.g. a tuple can be represented as a list of its component values) usually implements hashCode where the position of element matters, so for example the dates 2024-04-05 and 2024-05-04 would have different hash codes.
But if this type is internal and not used much in hashsets/maps, this consideration is minor and the hashCode can be implemented anyhow within its contract.
ilya-g
approved these changes
Oct 29, 2024
dkhalanskyjb
force-pushed
the
format-dayOfYear
branch
from
912124d to
63fecf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414