Track precise number of shared segment copies to return the last one into a segment pool #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two really nice Okio features kotlinx-io inherited:
Unfortunately, these two features don't work well together: once a segment is shared (and that is happening not only on explicit buffer copying but also in less obvious scenarios, like using the
PeekSource
), it will never be returned into a pool.The main cause is that the current "shared" state is tracked by a flag. It's easy to transfer from an unshared to a shared state, but there's no way back.
To address that issue, the shared state should be tracked using reference counting.
Obviously, such precision comes with a price, but state transitions and its checks are not that common, so it should be almost transparent performance-wise.