Update Service Descriptors Generation #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
force-pushed
the
service-descriptors
branch
from
c287665 to
9a89ff8
Compare
Mr3zee
force-pushed
the
service-descriptors
branch
from
9a89ff8 to
7ac04ad
Compare
Mr3zee
force-pushed
the
service-descriptors
branch
from
7ac04ad to
e440265
Compare
e5l
approved these changes
Nov 11, 2024
tests/compiler-plugin-tests/src/main/kotlin/kotlinx/rpc/codegen/test/TestRpcClient.kt
Show resolved
Hide resolved
whyoleg
reviewed
Nov 12, 2024
core/src/commonMain/kotlin/kotlinx/rpc/descriptor/RpcServiceDescriptor.kt
Show resolved
Hide resolved
core/src/commonMain/kotlin/kotlinx/rpc/descriptor/RpcServiceDescriptor.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/kotlinx/rpc/descriptor/RpcServiceDescriptor.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Core, Compiler Plugin
Problem Description
Current service descriptor API is not complete and overcomplicated. It lacks some info about the service, as well as some functionality
Solution
Introduce Descriptor API:
RpcServiceDescriptorwith a single entrypoint -serviceDescriptorOfRpcClientAPI